DistRen Changeset - 7c6860c8d8cd · protofusion repositories

Changeset - 7c6860c8d8cd

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Ethan Zonca (ethanzonca) - 15 years ago 2010-03-23 23:12:18
e@ethanzonca.com

Fixed stack smashing (hopefully)

1 file changed with 2 insertions and 2 deletions:

src/server/slavefuncs.c

0 comments (0 inline, 0 general)

src/server/slavefuncs.c

➞

Show inline comments

@@ @@ -795,30 +795,30 @@ int slaveBenchmark(char *datadir, int *b @@
   char *command = "blender"; // @TODO: We currently expect this to be in PATH
   char *cmd[] = { command, "-b", input, "-o", output, "-f", frame_str, "-t", "0", (char *)NULL }; // arguments for blender
   // fprintf(stderr,"Preparing to execute command: %s -b %s -o %s -f %s\n", command, input, output, frame_str);
   fprintf(stderr,"Running benchmark...\n");
   long startTime;
   long endTime;
   time(&startTime);
-  char buf[10];
+  char buf[20];
   struct execio *testrem;
   size_t readlen;
   ret = execio_open(&testrem, command, cmd);
-  buf[20] = '\0';
+  buf[19] = '\0';
   while(!execio_read(testrem, buf, 20, &readlen))
+    {
       if(readlen > 20) {
         fprintf(stderr, "Something is terribly wrong!\n");
+       }
        buf[readlen] = '\0';
        fprintf(stderr, "read \"%s\"\n", buf);
+    }
   execio_close(testrem);
   time(&endTime);

0 comments (0 inline, 0 general)