DistRen Changeset - c4b9cba6001c · protofusion repositories

Changeset - c4b9cba6001c

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Nathan Brink (binki) - 16 years ago 2009-07-26 09:00:20
ohnobinki@ohnopublishing.net

comments: distrencommon.conf:server section

2 files changed with 3 insertions and 2 deletions:

TODO

src/common/options.c

0 comments (0 inline, 0 general)

TODO

➞

Show inline comments

@@ @@ -17,17 +17,17 @@ Master @@
 x-frame_finder() needs to return both the job number and the frame number
 Slave
  -Fix current bugs
  -Add conf-file editing code where commented in register_user()
 *-Add calls to remoteio, once it works or even before it works
 *-Figure out how to get output back to the server!
  -Add code to write arguments for exec_blender based on the contents of a job's xml file
 *-Other XML-writing/reading
 Options
  -Rewrite some stuff, try to make it simpler
- -Move server and client confuse code into their individual files, rather than in the common file.
+x-Move server and client confuse code into their individual files, rather than in the common file. -- note: there wasn't any client code in options.c. There was the ``server'' section. That section is passed multiple times and provides information to remoteio on how to connect to servers
  -Review all confuse interfacing
  -Push patch for relative includes in confuse to the confuse developers
@@ \ No newline at end of file @@

src/common/options.c

➞

Show inline comments

@@ @@ -122,26 +122,27 @@ int options_init(int argc, char *argv[], @@
       return 1;
+    }
   memset((*allopts)->remoteio, '\0', sizeof(struct remoteio_opts));
   (*allopts)->remoteio->ssh_command = strdup("ssh");
   /** @TODO: check for NULL return above */
   cfg_opt_t common_opts[] =
+    {
       CFG_SIMPLE_STR("ssh-command", &(*allopts)->remoteio->ssh_command),
       CFG_END()
     };
   /*
+  /**
     In these arrays, I should replace NULL with a pointer to a string in the struct which should hold the result of confuse processing an option. This is partially because confuse will not free the values it parses.
     the server sections in the distrencommon.conf describe different servers that the client may connect to
    */
   cfg_opt_t server_opts[] =
+    {
       CFG_STR("username", NULL, CFGF_NONE),
       CFG_STR("hostname", NULL, CFGF_NONE),
       CFG_STR("method", "ssh", CFGF_NONE),
       CFG_STR_LIST("types", NULL, CFGF_NONE),
       CFG_END()
     };
   cfg_opt_t opts[] =
+    {

0 comments (0 inline, 0 general)