DistRen Changeset - ce23bfb50229 · protofusion repositories

Changeset - ce23bfb50229

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Nathan Brink (binki) - 16 years ago 2009-07-13 22:13:53
ohnobinki@ohnopublishing.net

fixed typos in remoteio, added missing #include, removed const

2 files changed with 5 insertions and 4 deletions:

src/common/remoteio.c

src/common/remoteio.h

0 comments (0 inline, 0 general)

src/common/remoteio.c

➞

Show inline comments

 /*
   Copyright 2009 Nathan Phillip Brink
   This file is a part of DistRen.
   DistRen is free software: you can redistribute it and/or modify
   it under the terms of the GNU Affero General Public License as published by
   the Free Software Foundation, either version 3 of the License, or
   (at your option) any later version.
   DistRen is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
   GNU Affero General Public License for more details.
   You should have received a copy of the GNU Affero General Public License
   along with DistRen.  If not, see <http://www.gnu.org/licenses/>.
 */
 #include "remoteio.h"
 #include "execio.h"
 #include <stdlib.h>
 #include <stdio.h>
 /**
    @todo there must be passage of a configuratoin struct to allow configuration of different ssh clients.
  */
-int remoteio_open(struct remoteio **rem, const char *servername)
 int remoteio_open(struct remoteio **rem, char *servername)
+{
-  const char *sshargs[] = {"ssh", servername, "distrend", "-d", (char *)NULL};
   char *sshargs[] = {"ssh", servername, "distrend", "-d", (char *)NULL};
   int rtn;
   *rem = malloc(sizeof(struct remoteio));
   rtn = execio_open( &(*rem)->execio, "ssh", sshargs);
   if(rtn)
+    {
-      fprinf(stderr, "error opening remoteio channel to server ``%s''" , servername);
+      fprintf(stderr, "error opening remoteio channel to server ``%s''" , servername);
       free(*rem);
       return 1;
+    }
   return 0;
+}

src/common/remoteio.h

➞

Show inline comments

 /*
   Copyright 2009 Nathan Phillip Brink, Ethan Zonca
   This file is a part of DistRen.
   DistRen is free software: you can redistribute it and/or modify
   it under the terms of the GNU Affero General Public License as published by
   the Free Software Foundation, either version 3 of the License, or
   (at your option) any later version.
   DistRen is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
   GNU Affero General Public License for more details.
   You should have received a copy of the GNU Affero General Public License
   along with DistRen.  If not, see <http://www.gnu.org/licenses/>.
 */
 #ifndef _DISTREN_REMOTEIO_H
 #define _DISTREN_REMOTEIO_H
 #include <stdlib.h>
 /*
   RemoteIO provides an abstraction to the method of talking to a remote distrend. It is a layer on top of execio that should provide an equivalent interface.
  */
 struct remoteio {
   struct execio *execio;
 };
 /**
    Opens connection with remote distrend. Returns 1 on error.
    @todo should this be asynchronous?
  */
-int remoteio_open(struct remoteio **rem, const char *servername);
 int remoteio_open(struct remoteio **rem, char *servername);
 /**
    non-blocking I/O.
    @return 0 on success, 1 on failure
  */
 int remoteio_read(struct remoteio *rem, void *buf, size_t len, size_t *bytesread);
 int remoteio_write(struct remoteio *rem, void *buf, size_t len, size_t *byteswritten);
 /**
    Closes a remoteio session.
    @return nonzero on error
 */
 int remoteio_close(struct remoteio *rem);
 #endif

0 comments (0 inline, 0 general)