Changeset - abf87bb26d64
[Not reviewed]
default
0 1 0
Nathan Brink (binki) - 14 years ago 2012-02-10 21:38:53
ohnobinki@ohnopublishing.net
Add missing alt attribute to Google AdWords Conversion image.
1 file changed with 1 insertions and 1 deletions:
0 comments (0 inline, 0 general)
inc/class.page.php
Show inline comments
 
@@ -270,49 +270,49 @@ class page
 
	$conversion_referrer = empty($_SERVER['HTTP_REFERER']) ? '' : '&ref=' . rawurlencode(substr($_SERVER['HTTP_REFERER'], 0, 255));
 
	$js_Date_getTime = (1000 * time()) . sprintf("%03d", rand(0, 999));
 

	
 
	$i = 1;
 
	foreach ($ga_conversions as $conversion_id => $conversion_label)
 
	  /*
 
	   * For random, supplement time() with three numerals to look
 
	   * like milliseconds like JavaScript's Date.getTime()
 
	   * function. For some reason, `random' and `fst' (first
 
	   * conversion time?) are both set to the current time. I'm
 
	   * guessing that random is supposed to be a cachebreaker.
 
	   *
 
	   * `cv' is the `current version' of the Google conversion.js
 
	   * which is 7. This could be scraped from the .js by looking
 
	   * for `google_conversion_js_version="7"'.
 
	   *
 
	   * `fmt=3' must mean that we don't want the user-notification
 
	   * to appear, but we already don't show that.  `value=0'
 
	   * seems to have no meaning at all, maybe it is supposed to
 
	   * be the `priority' of this conversion point.
 
	   *
 
	   * Google's `hl' and `gl' language values should probably be
 
	   * appended.
 
	   */
 
	  $this->ga_conversions_code .= '<img style="width: 1px; height: 1px; border: none;" src="'
 
	  $this->ga_conversions_code .= '<img alt="" style="width: 1px; height: 1px; border: none;" src="'
 
	  . htmlentities($conversion_base_href . $conversion_id . '/?random=' . $js_Date_getTime . '&cv=7&fst=' . $js_Date_getTime
 
			 . '&num=' . $i++ . '&fmt=3&value=0&label=' . $conversion_label . '&bg=ffffff'
 
			 . '&guid=ON&disvt=&is_call=' . $conversion_referrer,
 
			 ENT_QUOTES)
 
	  . '" ' . ($this->xhtml ? '/' : '') . '>';
 
      }
 
  }
 

	
 
  /**
 
   * \brief
 
   *   Set a meta element value.
 
   * \param $name
 
   *   The name of the meta attribute.
 
   * \param $value
 
   *   The value.
 
   */
 
  public function meta($name, $value = '')
 
  {
 
    $this->meta[$name] = $value;
 
  }
 

	
 
  /**
 
   * \brief
 
   *   Set the information necessary to create a canonical URI
0 comments (0 inline, 0 general)