SlatePermutate Changeset - d1667e00dc71 · protofusion repositories

Changeset - d1667e00dc71

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Nathan Brink (binki) - 14 years ago 2011-05-28 14:02:20
ohnobinki@ohnopublishing.net

XHTML validation on feedback form page.

1 file changed with 18 insertions and 12 deletions:

feedback.php

0 comments (0 inline, 0 general)

feedback.php

➞

Show inline comments

@@ @@ -29,77 +29,83 @@ require_once 'inc/class.schedule.php'; @@
 $referrer = '';
 if (!empty($_SERVER['HTTP_REFERER']))
   $referrer = $_SERVER['HTTP_REFERER'];
 if (!empty($_POST['referrer']))
   $referrer = $_POST['referrer'];
 $saved_schedules = array();
 if (!empty($_SESSION['saved']))
   foreach ($_SESSION['saved'] as $key => $val)
     $saved_schedules[] = '<a href="' . htmlentities(Schedule::url($key)) . '">' . htmlentities($key) . '</a>';
 $saved_schedules = implode(', ', $saved_schedules);
 /* some prefill support */
 $school = $feedbackpage->get_school();
 $feedback_text = '';
 if (isset($_GET['feedback']))
   $feedback_text = $_GET['feedback'];
 $n = "\n";
 ?>
 <form action="feedback-submit.php" method="post">
 <input type="hidden" name="ip" value="<?php echo $ipi ?>" />
 <input type="hidden" name="fromdom" value="<?php echo $fromdom ?>" />
 <input type="hidden" name="httpagent" value="<?php echo $httpagenti ?>" />
 <div id="feedback-form-content">
 <input type="hidden" id="ip" name="ip" value="<?php echo $ipi ?>" />
 <input type="hidden" id="fromdom" name="fromdom" value="<?php echo $fromdom ?>" />
 <input type="hidden" id="httpagent" name="httpagent" value="<?php echo $httpagenti ?>" />
 <table>
 <tr><td><label for="nameis">Name: </label></td><td><input type="text" name="nameis" size="20" /></td></tr>
 <tr><td><label for="visitormail">Email:</label></td><td><input type="text" name="visitormail" size="20" /></td></tr>
 <tr><td><label for="school">School: </label></td><td><input type="text" name="school" value="<?php echo htmlentities($school['id']); ?>" size="20" /> <span class="graytext">(if relevant to your feedback)</span></td></tr>
   <tr><td><label for="referrer">Relevant Page:</label></td><td><input type="text" name="referrer" value="<?php echo htmlentities($referrer); ?>" size="20" /> <span class="graytext">(if relevant to your feedback)</span></td></tr>
 <tr><td><label for="nameis">Name: </label></td><td><input type="text" id="nameis" name="nameis" size="20" /></td></tr>
 <tr><td><label for="visitormail">Email:</label></td><td><input type="text" id="visitormail" name="visitormail" size="20" /></td></tr>
 <tr><td><label for="school">School: </label></td><td><input type="text" id="school" name="school" value="<?php echo htmlentities($school['id']); ?>" size="20" /> <span class="graytext">(if relevant to your feedback)</span></td></tr>
   <tr><td><label for="referrer">Relevant Page:</label></td><td><input type="text" id="referrer" name="referrer" value="<?php echo htmlentities($referrer); ?>" size="20" /> <span class="graytext">(if relevant to your feedback)</span></td></tr>
 </table>
 <br/> Overall Rating:<br/> <input checked="checked" name="rating" type="radio" value="Great" />Great <input name="rating" type="radio" value="Usable" />Usable  <input name="rating" type="radio" value="Buggy/Hard to Use" />Buggy/Hard to Use <input name="rating" type="radio" value="Don't know" />Don't Know <!-- ' -->
 <br /><br />
 <br/>
 <div id="ratings">
   <div id="ratings-label">Overall Rating:</div>
   <input checked="checked" id="rating-great" name="rating" type="radio" value="Great" /><label for="rating-great">Great</label>
   <input id="rating-usable" name="rating" type="radio" value="Usable" /><label for="rating-usable">Usable</label>
   <input id="rating-buggy" name="rating" type="radio" value="Buggy/Hard to Use" /><label for="rating-buggy">Buggy/Hard to Use</label>
   <input id="rating-unknown" name="rating" type="radio" value="Don't know" /><label for="rating-unknown">Don't Know <!-- ' --></label>
 </div>
 <h3>General Comments</h3>
 <p>
   <textarea name="feedback" rows="6" cols="40"><?php echo htmlentities($feedback_text); ?></textarea>
 </p>
 <?php
     if ($use_captcha)
+    {
       echo '' . $n
       . '  <h3>Captcha</h3>' . $n
       . '<p>' . $n
       . '  <img id="captcha_img" src="captcha_img.php" alt="captcha image" /><br />' . $n
       . '  <label for="captcha_code">Enter the obfuscated text from the above image:</label><br />' . $n
-      . '  <input name="captcha_code" type="textbox" />' . $n
+      . '  <input id="captcha_code" name="captcha_code" type="text" />' . $n
       . '</p>' . $n;
+    }
 ?>
 <input class="gray" type="submit" value="Send Feedback" />
 <?php if (!empty($saved_schedules)): ?>
 <p class="graytext" style="margin-top: 20pt;">
   The following information will also be submitted when you send feedback:
 </p>
 <table class="graytext">
   <tr>
     <th>Type</th>
     <th>Value</th>
   </tr>
   <tr>
   <td>Saved Schedules:</td>
     <td><?php echo $saved_schedules; ?></td>
   </tr>
 </table>
 <?php endif; ?>
+</div>
 </form>
 <?php
 $feedbackpage->foot();

0 comments (0 inline, 0 general)