SlatePermutate Changeset - f5b8a6f32c9a · protofusion repositories

Changeset - f5b8a6f32c9a

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Nathan Brink (binki) - 15 years ago 2010-11-04 10:26:05
ohnobinki@ohnopublishing.net

Actually reject bad input for the feedback form instead of detecting it but still allowing it through.

1 file changed with 10 insertions and 3 deletions:

feedback-submit.php

0 comments (0 inline, 0 general)

feedback-submit.php

➞

Show inline comments

@@ @@ -21,17 +21,23 @@ Page::session_start(); @@
 $feedback = $_POST['feedback'];
 $rating = $_POST['rating'];
 $reject = FALSE;
 if (eregi('http:', $feedback)) {
   echo 'Please do not include URLs in your submission! Please click "back" and try again.';
   $reject = TRUE;
+}
-if((!$visitormail == '') && (!strstr($visitormail, '@') || !strstr($visitormail, '.'))) {
+if (empty($visitormail) || !preg_match('/^[^@]+@[^@]+\.[^@]+$/', $visitormail)) {
   echo '<p>Please click "back" and enter valid e-mail address.</p>';
   $reject = TRUE;
+}
 if(empty($nameis) || empty($feedback) || empty($visitormail)) {
   echo '<p>Please click "back" and fill in all fields.</p>';
   $reject = TRUE;
+}
 if (!$reject)
+  {
 $feedback = stripcslashes($feedback);
 $message = date('l, F j, Y, g:i a') ."
@@ @@ -53,7 +59,6 @@ foreach($feedback_emails as $toaddr) @@
     mail($toaddr, $subject, $message, $from);
+  }
 ?>
 <p>Thanks for helping make SlatePermutate better. Your feedback is greatly appreciated.</p>
@@ @@ -61,4 +66,6 @@ foreach($feedback_emails as $toaddr) @@
 <?php
+  }
   $feedbackpage->foot();

0 comments (0 inline, 0 general)