seniordesign-firmware Changeset - 61c1fe267ce2

Changeset - 61c1fe267ce2

Parent rev.

Child rev.

[Not reviewed]

default

0 3 0

ethanzonca@CL-SEC241-08.cedarville.edu - 12 years ago 2012-12-03 18:57:03
ethanzonca@CL-SEC241-08.cedarville.edu

Resolved FS#29 - Serial checksum may match special character

3 files changed with 32 insertions and 15 deletions:

master/master/lib/serial.c

master/master/lib/serparser.c

master/master/lib/serparser.h

0 comments (0 inline, 0 general)

master/master/lib/serial.c

➞

Show inline comments

@@ @@ -116,8 +116,9 @@ void serial_sendCommand( char moduleID, @@
 		data++;
+	}
-	serial0_sendChar(checkSum);
 	serial0_sendChar(']'); //bracket indicates end of command
 	serial0_sendChar(checkSum); // checksum moved behind bracket to solve bug FS#29
+}
 void serial_sendResponseData()

master/master/lib/serparser.c

➞

Show inline comments

@@ @@ -149,19 +149,11 @@ int serparser_parse(void) @@
 				sprintf(buffmeh, "recvd %d bytes data\r\n", dataLength);
 				serial0_sendString((buffmeh));
 				#endif
 				if(bufferParsePosition == bufferDataPosition)
+				{
 					// We are at the end of the line. No more data to parse.
 					setParserState(STATE_RESET);
 					return PARSERESULT_PARSEOK;
+				}
 				else
+				{
 					setParserState(STATE_RESET);
 					// we could choose to keep parsing now, or parse the next message next loop around (better idea).
 					// return now so we hit it the next time around
 					return PARSERESULT_PARSEOK;
+				}
 				setParserState(STATE_GETCHECKSUM);
 				// Checksum is now after the close bracket to solve bug FS#29
+			}
 			else // Still receiving data
+			{
@@ @@ -189,6 +181,29 @@ int serparser_parse(void) @@
+			}
+		}
 		else if(STATE_GETCHECKSUM)
+		{
 			// TODO: Compare checksums
 			if(byte == checksumCalc) {
 				serial0_sendString("checksum ok\r\n");
+			}
 			else {
 				serial0_sendString("checksum fail\r\n");
+			}
 			if(bufferParsePosition == bufferDataPosition)
+			{
 				// We are at the end of the line. No more data to parse.
 				setParserState(STATE_RESET);
 				return PARSERESULT_PARSEOK;
+			}
 			else
+			{
 				setParserState(STATE_RESET);
 				// we could choose to keep parsing now, or parse the next message next loop around (better idea).
 				// return now so we hit it the next time around
 				return PARSERESULT_PARSEOK;
+			}
+		}
+	}
 	return PARSERESULT_NODATA;

master/master/lib/serparser.h

➞

Show inline comments

@@ @@ -28,7 +28,8 @@ enum parseStates @@
 	STATE_RESET = 0,
 	STATE_GETID,
 	STATE_GETDATATYPE,
 	STATE_GETDATA
 	STATE_GETDATA,
 	STATE_GETCHECKSUM,
 };
 // Prototypes

0 comments (0 inline, 0 general)