Files
        @ ad511482dde1
    
        
              Branch filter: 
        
    Location: tempo-plotter/src/asciireader.cpp - annotation
        
            
            ad511482dde1
            4.6 KiB
            text/x-c++hdr
        
        
    
    fix potential memory leak, dynamically created object needs a parent
    1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174  | ecd02467c397 0894be6d3943 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ce36704ede6f ce36704ede6f ce36704ede6f e0c6c43cbcf5 e0c6c43cbcf5 e0c6c43cbcf5 ecd02467c397 ecd02467c397 50d42af49411 ecd02467c397 ecd02467c397 ce36704ede6f ce36704ede6f ecd02467c397 ce36704ede6f ce36704ede6f ce36704ede6f ce36704ede6f ce36704ede6f ce36704ede6f ce36704ede6f ce36704ede6f ce36704ede6f 50d42af49411 50d42af49411 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 2fb7fd9515d1 2fb7fd9515d1 2fb7fd9515d1 2fb7fd9515d1 2fb7fd9515d1 2fb7fd9515d1 2fb7fd9515d1 2fb7fd9515d1 2fb7fd9515d1 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 50d42af49411 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 50d42af49411 50d42af49411 50d42af49411 50d42af49411 50d42af49411 50d42af49411 50d42af49411 ecd02467c397 ecd02467c397 ecd02467c397 fa8cb0995e3e ecd02467c397 ecd02467c397 50d42af49411 ecd02467c397 934c1d1050b2 934c1d1050b2 934c1d1050b2 934c1d1050b2 934c1d1050b2 934c1d1050b2 934c1d1050b2 934c1d1050b2 934c1d1050b2 ecd02467c397 ecd02467c397 ce36704ede6f ce36704ede6f ce36704ede6f ce36704ede6f ce36704ede6f ce36704ede6f ce36704ede6f ce36704ede6f ce36704ede6f ce36704ede6f ce36704ede6f ce36704ede6f ce36704ede6f ce36704ede6f ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 ecd02467c397 c1bf9f78ee55 ecd02467c397 ecd02467c397 ecd02467c397 0894be6d3943 ce36704ede6f ecd02467c397 ecd02467c397 0894be6d3943 0894be6d3943 ecd02467c397 ecd02467c397 c1bf9f78ee55 0894be6d3943 ecd02467c397 ecd02467c397 0894be6d3943 0894be6d3943 538d40c57b2b 0894be6d3943 0894be6d3943 ecd02467c397 ecd02467c397 5b3f4916ebcf 5b3f4916ebcf 5b3f4916ebcf 5b3f4916ebcf 5b3f4916ebcf 5b3f4916ebcf 5b3f4916ebcf 5b3f4916ebcf 5b3f4916ebcf 5b3f4916ebcf  | /*
  Copyright © 2017 Hasan Yavuz Özderya
  This file is part of serialplot.
  serialplot is free software: you can redistribute it and/or modify
  it under the terms of the GNU General Public License as published by
  the Free Software Foundation, either version 3 of the License, or
  (at your option) any later version.
  serialplot is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU General Public License for more details.
  You should have received a copy of the GNU General Public License
  along with serialplot.  If not, see <http://www.gnu.org/licenses/>.
*/
#include <QtDebug>
#include "asciireader.h"
/// If set to this value number of channels is determined from input
#define NUMOFCHANNELS_AUTO   (0)
AsciiReader::AsciiReader(QIODevice* device, ChannelManager* channelMan,
                         DataRecorder* recorder, QObject* parent) :
    AbstractReader(device, channelMan, recorder, parent)
{
    paused = false;
    discardFirstLine = true;
    _numOfChannels = _settingsWidget.numOfChannels();
    autoNumOfChannels = (_numOfChannels == NUMOFCHANNELS_AUTO);
    connect(&_settingsWidget, &AsciiReaderSettings::numOfChannelsChanged,
            [this](unsigned value)
            {
                _numOfChannels = value;
                autoNumOfChannels = (_numOfChannels == NUMOFCHANNELS_AUTO);
                if (!autoNumOfChannels)
                {
                    emit numOfChannelsChanged(value);
                }
            });
    connect(device, &QIODevice::aboutToClose, [this](){discardFirstLine=true;});
}
QWidget* AsciiReader::settingsWidget()
{
    return &_settingsWidget;
}
unsigned AsciiReader::numOfChannels()
{
    // do not allow '0'
    if (_numOfChannels == 0)
    {
        return 1;
    }
    else
    {
        return _numOfChannels;
    }
}
// TODO: this could be a part of AbstractReader
void AsciiReader::enable(bool enabled)
{
    if (enabled)
    {
        discardFirstLine = true;
        QObject::connect(_device, &QIODevice::readyRead,
                         this, &AsciiReader::onDataReady);
    }
    else
    {
        QObject::disconnect(_device, 0, this, 0);
    }
}
void AsciiReader::pause(bool enabled)
{
    paused = enabled;
}
void AsciiReader::onDataReady()
{
    while(_device->canReadLine())
    {
        QByteArray line = _device->readLine();
        // discard only once when we just started reading
        if (discardFirstLine)
        {
            discardFirstLine = false;
            continue;
        }
        // discard data if paused
        if (paused)
        {
            continue;
        }
        // parse data
        line = line.trimmed();
        // Note: When data coming from pseudo terminal is buffered by
        // system CR is converted to LF for some reason. This causes
        // empty lines in the input when the port is just opened.
        if (line.isEmpty())
        {
            continue;
        }
        auto separatedValues = line.split(',');
        unsigned numReadChannels; // effective number of channels to read
        unsigned numComingChannels = separatedValues.length();
        if (autoNumOfChannels)
        {
            // did number of channels changed?
            if (numComingChannels != _numOfChannels)
            {
                _numOfChannels = numComingChannels;
                emit numOfChannelsChanged(numComingChannels);
            }
            numReadChannels = numComingChannels;
        }
        else if (numComingChannels >= _numOfChannels)
        {
            numReadChannels = _numOfChannels;
        }
        else // there is missing channel data
        {
            numReadChannels = separatedValues.length();
            qWarning() << "Incoming data is missing data for some channels!";
            qWarning() << "Read line: " << line;
        }
        // parse read line
        double* channelSamples = new double[_numOfChannels]();
        for (unsigned ci = 0; ci < numReadChannels; ci++)
        {
            bool ok;
            channelSamples[ci] = separatedValues[ci].toDouble(&ok);
            if (!ok)
            {
                qWarning() << "Data parsing error for channel: " << ci;
                qWarning() << "Read line: " << line;
                channelSamples[ci] = 0;
            }
        }
        // commit data
        addData(channelSamples, _numOfChannels);
        delete[] channelSamples;
    }
}
void AsciiReader::saveSettings(QSettings* settings)
{
    _settingsWidget.saveSettings(settings);
}
void AsciiReader::loadSettings(QSettings* settings)
{
    _settingsWidget.loadSettings(settings);
}
 |