# HG changeset patch # User Hasan Yavuz Ă–ZDERYA # Date 2018-03-30 10:39:35 # Node ID c3e7e4cfc78deebfb176d721542e50d7fbbe9b19 # Parent d5f251708ffbbebc80580295dc3cf460d7bf1bb9 prefer early failure of if statement, skip requests are rare diff --git a/src/binarystreamreader.cpp b/src/binarystreamreader.cpp --- a/src/binarystreamreader.cpp +++ b/src/binarystreamreader.cpp @@ -133,7 +133,7 @@ void BinaryStreamReader::onDataReady() int bytesAvailable = _device->bytesAvailable(); // skip 1 byte if requested - if (bytesAvailable > 0 && skipByteRequested) + if (skipByteRequested && bytesAvailable > 0) { _device->read(1); skipByteRequested = false; @@ -141,7 +141,7 @@ void BinaryStreamReader::onDataReady() } // skip 1 sample (channel) if requested - if (bytesAvailable >= (int) sampleSize && skipSampleRequested) + if (skipSampleRequested && bytesAvailable >= (int) sampleSize) { _device->read(sampleSize); skipSampleRequested = false;