tempo-plotter Changeset - 2c5e57ebc103 · protofusion repositories

Changeset - 2c5e57ebc103

Parent rev.

Child rev.

[Not reviewed]

stream

0 4 0

Hasan Yavuz ÖZDERYA - 8 years ago 2018-04-03 16:08:38
hy@ozderya.net

remove ambiguity with `QObject::sink` method

4 files changed with 10 insertions and 10 deletions:

src/source.cpp

src/source.h

tests/test.cpp

tests/test_stream.cpp

0 comments (0 inline, 0 general)

src/source.cpp

➞

Show inline comments

@@ @@ -29,7 +29,7 @@ Source::~Source() @@
+    }
+}
-void Source::connect(Sink* sink)
+void Source::connectSink(Sink* sink)
+{
     Q_ASSERT(!sinks.contains(sink));
     Q_ASSERT(sink->connectedSource() == NULL);

src/source.h

➞

Show inline comments

@@ @@ -39,7 +39,7 @@ public: @@
     /// Connects a sink to this source. Trying to connect an already
     /// connected sink is an error.
-    void connect(Sink* sink);
+    void connectSink(Sink* sink);
     /// Disconnects an already connected sink. Trying to disconnect an
     /// unconnected sink is an error.

tests/test.cpp

➞

Show inline comments

@@ @@ -98,7 +98,7 @@ TEST_CASE("source", "[memory, stream]") @@
     REQUIRE(source.numChannels() == 3);
     REQUIRE(source.hasX() == false);
-    source.connect(&sink);
+    source.connectSink(&sink);
     REQUIRE(sink.numChannels() == 3);
     REQUIRE(sink.hasX() == false);
@@ @@ -120,7 +120,7 @@ TEST_CASE("source must set/unset sink 's @@
     TestSink sink;
     TestSource source(3, false);
-    source.connect(&sink);
+    source.connectSink(&sink);
     REQUIRE(sink.connectedSource() == &source);
     source.disconnect(&sink);
@@ @@ -135,7 +135,7 @@ TEST_CASE("source disconnect all sinks", @@
     // connect sinks
     for (int i = 0; i < 3; i++)
+    {
-        source.connect(&sinks[i]);
+        source.connectSink(&sinks[i]);
+    }
     source.disconnectSinks();

tests/test_stream.cpp

➞

Show inline comments

@@ @@ -52,7 +52,7 @@ TEST_CASE("changing stream number of cha @@
+{
     Stream s;
     TestSource so(3, false);
-    so.connect(&s);
+    so.connectSink(&s);
     // nc=3, x= false
     REQUIRE(s.numChannels() == 3);
@@ @@ -106,7 +106,7 @@ TEST_CASE("adding data to a stream with @@
+    }
     TestSource so(3, false);
-    so.connect(&s);
+    so.connectSink(&s);
     // test
     so._feed(pack);
@@ @@ -147,7 +147,7 @@ TEST_CASE("adding data to a stream with @@
+    }
     TestSource so(3, true);
-    so.connect(&s);
+    so.connectSink(&s);
     // test
     so._feed(pack);
@@ @@ -194,7 +194,7 @@ TEST_CASE("paused stream shouldn't store @@
+    }
     TestSource so(3, false);
-    so.connect(&s);
+    so.connectSink(&s);
     // test
     s.pause(true);
@@ @@ -227,7 +227,7 @@ TEST_CASE("clear stream data", "[memory, @@
+    }
     TestSource so(3, false);
-    so.connect(&s);
+    so.connectSink(&s);
     // test
     so._feed(pack);

0 comments (0 inline, 0 general)