tempo-plotter Changeset - f0efea025c96 · protofusion repositories

Changeset - f0efea025c96

Parent rev.

Child rev.

[Not reviewed]

default

0 3 0

Hasan Yavuz ÖZDERYA - 9 years ago 2017-02-06 16:22:19
hy@ozderya.net

fix delete operators, potential memory leak

3 files changed with 3 insertions and 3 deletions:

src/binarystreamreader.cpp

src/framebuffer.cpp

src/framedreader.cpp

0 comments (0 inline, 0 general)

src/binarystreamreader.cpp

➞

Show inline comments

@@ @@ -170,25 +170,25 @@ void BinaryStreamReader::onDataReady() @@
             channelSamples[ci*numOfPackagesToRead+i] = (this->*readSample)();
+        }
+    }
     for (unsigned int ci = 0; ci < _numOfChannels; ci++)
+    {
         addChannelData(ci,
                        channelSamples + ci*numOfPackagesToRead,
                        numOfPackagesToRead);
+    }
     emit dataAdded();
     delete channelSamples;
+    delete[] channelSamples;
+}
 template<typename T> double BinaryStreamReader::readSampleAs()
+{
     T data;
     _device->read((char*) &data, sizeof(data));
     if (_settingsWidget.endianness() == LittleEndian)
+    {
         data = qFromLittleEndian(data);
+    }

src/framebuffer.cpp

➞

Show inline comments

@@ @@ -21,25 +21,25 @@ @@
 FrameBuffer::FrameBuffer(size_t size)
+{
     _size = size;
     data = new double[_size]();
     headIndex = 0;
     _boundingRect.setCoords(0, 0, size, 0);
+}
 FrameBuffer::~FrameBuffer()
+{
     delete data;
+    delete[] data;
+}
 void FrameBuffer::resize(size_t size)
+{
     int offset = size - _size;
     if (offset == 0) return;
     double* newData = new double[size];
     // move data to new array
     int fill_start = offset > 0 ? offset : 0;

src/framedreader.cpp

➞

Show inline comments

@@ @@ -316,25 +316,25 @@ void FramedReader::readFrameDataAndCheck @@
                 ci,
                 channelSamples + ci*numOfPackagesToRead,
                 numOfPackagesToRead);
             sampleCount += numOfPackagesToRead;
+        }
         emit dataAdded();
+    }
     else
+    {
         qCritical() << "Checksum failed! Received:" << rChecksum << "Calculated:" << calcChecksum;
+    }
     delete channelSamples;
+    delete[] channelSamples;
+}
 template<typename T> double FramedReader::readSampleAs()
+{
     T data;
     _device->read((char*) &data, sizeof(data));
     if (checksumEnabled)
+    {
         for (unsigned i = 0; i < sizeof(data); i++)
+        {

0 comments (0 inline, 0 general)