tempo-plotter Changeset - f0efea025c96 · protofusion repositories

Changeset - f0efea025c96

Parent rev.

Child rev.

[Not reviewed]

default

0 3 0

Hasan Yavuz ÖZDERYA - 9 years ago 2017-02-06 16:22:19
hy@ozderya.net

fix delete operators, potential memory leak

3 files changed with 3 insertions and 3 deletions:

src/binarystreamreader.cpp

src/framebuffer.cpp

src/framedreader.cpp

0 comments (0 inline, 0 general)

src/binarystreamreader.cpp

➞

Show inline comments

@@ @@ -176,13 +176,13 @@ void BinaryStreamReader::onDataReady() @@
         addChannelData(ci,
                        channelSamples + ci*numOfPackagesToRead,
                        numOfPackagesToRead);
+    }
     emit dataAdded();
     delete channelSamples;
+    delete[] channelSamples;
+}
 template<typename T> double BinaryStreamReader::readSampleAs()
+{
     T data;

src/framebuffer.cpp

➞

Show inline comments

@@ @@ -27,13 +27,13 @@ FrameBuffer::FrameBuffer(size_t size) @@
     _boundingRect.setCoords(0, 0, size, 0);
+}
 FrameBuffer::~FrameBuffer()
+{
     delete data;
+    delete[] data;
+}
 void FrameBuffer::resize(size_t size)
+{
     int offset = size - _size;
     if (offset == 0) return;

src/framedreader.cpp

➞

Show inline comments

@@ @@ -322,13 +322,13 @@ void FramedReader::readFrameDataAndCheck @@
+    }
     else
+    {
         qCritical() << "Checksum failed! Received:" << rChecksum << "Calculated:" << calcChecksum;
+    }
     delete channelSamples;
+    delete[] channelSamples;
+}
 template<typename T> double FramedReader::readSampleAs()
+{
     T data;

0 comments (0 inline, 0 general)