tempo-plotter Changeset - fff236a1193a · protofusion repositories

Changeset - fff236a1193a

Parent rev.

Child rev.

[Not reviewed]

default

0 3 0

Mehmet ASLAN - 7 years ago 2018-06-24 08:17:37
aaslan.mehmet@hotmail.com

re-implemented functions made explicit
unnecessary line deleted

3 files changed with 2 insertions and 3 deletions:

src/asciireader.cpp

src/asciireader.h

src/demoreader.h

0 comments (0 inline, 0 general)

src/asciireader.cpp

➞

Show inline comments

@@ @@ -66,25 +66,24 @@ unsigned AsciiReader::numChannels() cons @@
+}
 void AsciiReader::enable(bool enabled)
+{
     if (enabled)
+    {
         firstReadAfterEnable = true;
         QObject::connect(_device, &QIODevice::readyRead,
                          this, &AsciiReader::onDataReady);
+    }
     else
+    {
         firstReadAfterEnable = false;
         QObject::disconnect(_device, 0, this, 0);
         disconnectSinks();
+    }
+}
 void AsciiReader::onDataReady()
+{
     while(_device->canReadLine())
+    {
         QString line = QString(_device->readLine());
         // discard only once when we just started reading

src/asciireader.h

➞

Show inline comments

@@ @@ -24,25 +24,25 @@ @@
 #include "abstractreader.h"
 #include "asciireadersettings.h"
 class AsciiReader : public AbstractReader
+{
     Q_OBJECT
 public:
     explicit AsciiReader(QIODevice* device, QObject *parent = 0);
     QWidget* settingsWidget();
     unsigned numChannels() const;
     void enable(bool enabled);
+    void enable(bool enabled) override;
     /// Stores settings into a `QSettings`
     void saveSettings(QSettings* settings);
     /// Loads settings from a `QSettings`.
     void loadSettings(QSettings* settings);
 private:
     AsciiReaderSettings _settingsWidget;
     unsigned _numChannels;
     /// number of channels will be determined from incoming data
     unsigned autoNumOfChannels;
     QChar delimiter; ///< selected column delimiter

src/demoreader.h

➞

Show inline comments

@@ @@ -34,25 +34,25 @@ @@
+ *
  * This reader should not be enabled when port is open!
  */
 class DemoReader : public AbstractReader
+{
     Q_OBJECT
 public:
     explicit DemoReader(QIODevice* device, QObject* parent = 0);
     QWidget* settingsWidget();
     unsigned numChannels() const;
     void enable(bool enabled = true);
+    void enable(bool enabled = true) override;
 public slots:
     void setNumChannels(unsigned value);
 private:
     DemoReaderSettings _settingsWidget;
     unsigned _numChannels;
     QTimer timer;
     int count;
 private slots:

0 comments (0 inline, 0 general)