seniordesign-firmware Changeset - 84e25f7efd5a

Changeset - 84e25f7efd5a

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

ethanzonca@CL-ENS241-08.cedarville.edu - 12 years ago 2013-04-18 21:51:21
ethanzonca@CL-ENS241-08.cedarville.edu

Fixed issue where get_latitudeTrimmed() and get_latitudeLSBs() and associated longitude function returned the same results due to buffer sharing and compiler optimization.

1 file changed with 16 insertions and 14 deletions:

master/master/lib/gps.c

0 comments (0 inline, 0 general)

master/master/lib/gps.c

➞

Show inline comments

@@ @@ -45,76 +45,78 @@ volatile uint16_t nmeaBufferDataPosition @@
 // holds the byte ALREADY PARSED. includes starting character
 int bytesReceived = 0;
 //data (and checksum) of most recent transmission
 char data[16];
 //used to skip over bytes during parse
 int skipBytes = 0;
 //used to index data arrays during data collection
 int numBytes = 0;
 //variables to store data from transmission
 //least significant digit is stored at location 0 of arrays
 char tramsmissionType[7];
 char timestamp[12];	//hhmmss.ss
 char* get_timestamp()
+{
 	return timestamp;
+}
 char latitude[14];	//lllll.lla
 char latitudeTmp[8];
 char latitudeTmpTRIM[8];
 char latitudeTmpLSB[4];
 char* get_latitudeTrimmed()
+{
 	strncpy(latitudeTmp, &latitude[0], 7);
 	latitudeTmp[7] = 0x00;
 	return latitudeTmp;
 	strncpy(latitudeTmpTRIM, &latitude[0], 7);
 	latitudeTmpTRIM[7] = 0x00;
 	return latitudeTmpTRIM;
+}
 char* get_latitudeLSBs()
+{
 	strncpy(latitudeTmp, &latitude[7], 3);
 	latitudeTmp[3] = 0x00;
 	return latitudeTmp;
 	strncpy(latitudeTmpLSB, &latitude[7], 3);
 	latitudeTmpLSB[3] = 0x00;
 	return latitudeTmpLSB;
+}
 char longitude[14];	//yyyyy.yyb
 char longitudeTmp[9];
 char longitudeTmpTRIM[9];
 char longitudeTmpLSB[4];
 char* get_longitudeTrimmed()
+{
 	strncpy(longitudeTmp, &longitude[0], 8);
 	longitudeTmp[8] = 0x00;
 	return longitudeTmp;
 	strncpy(longitudeTmpTRIM, &longitude[0], 8);
 	longitudeTmpTRIM[8] = 0x00;
 	return longitudeTmpTRIM;
+}
 char* get_longitudeLSBs()
+{
 	strncpy(longitudeTmp, &longitude[8], 3);
 	longitudeTmp[3] = 0x00;
 	return longitudeTmp;
 	strncpy(longitudeTmpLSB, &longitude[8], 3);
 	longitudeTmpLSB[3] = 0x00;
 	return longitudeTmpLSB;
+}
 char quality;		//quality for GGA and validity for RMC
 char numSatellites[4];
 char* get_sv()
+{
 	return numSatellites;
+}
 char hdop[6];		//xx.x
 char* get_hdop()
+{
 	return hdop;
+}
 char altitude[10];	//xxxxxx.x
 char* get_gpsaltitude()
+{
 	return altitude;
+}
 char wgs84Height[8];	//sxxx.x
 char lastUpdated[8];	//blank - included for testing
 char stationID[8];	//blank - included for testing

0 comments (0 inline, 0 general)