tempo-plotter Changeset - c3e7e4cfc78d · protofusion repositories

Changeset - c3e7e4cfc78d

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Hasan Yavuz ÖZDERYA - 8 years ago 2018-03-30 10:39:35
hy@ozderya.net

prefer early failure of if statement, skip requests are rare

1 file changed with 2 insertions and 2 deletions:

src/binarystreamreader.cpp

0 comments (0 inline, 0 general)

src/binarystreamreader.cpp

➞

Show inline comments

@@ @@ -130,21 +130,21 @@ void BinaryStreamReader::onDataReady() @@
+{
     // a package is a set of channel data like {CHAN0_SAMPLE, CHAN1_SAMPLE...}
     int packageSize = sampleSize * _numOfChannels;
     int bytesAvailable = _device->bytesAvailable();
     // skip 1 byte if requested
-    if (bytesAvailable > 0 && skipByteRequested)
+    if (skipByteRequested && bytesAvailable > 0)
+    {
         _device->read(1);
         skipByteRequested = false;
         bytesAvailable--;
+    }
     // skip 1 sample (channel) if requested
-    if (bytesAvailable >= (int) sampleSize && skipSampleRequested)
+    if (skipSampleRequested && bytesAvailable >= (int) sampleSize)
+    {
         _device->read(sampleSize);
         skipSampleRequested = false;
         bytesAvailable -= sampleSize;
+    }

0 comments (0 inline, 0 general)